fix unit tests for HttpRequestService.ts

This commit is contained in:
Hazelnoot 2025-05-13 22:27:18 -04:00
parent e914be3694
commit b888ff931d

View file

@ -16,8 +16,8 @@ describe(HttpRequestService, () => {
beforeEach(() => { beforeEach(() => {
allowedPrivateNetworks = parsePrivateNetworks([ allowedPrivateNetworks = parsePrivateNetworks([
'10.0.0.1/32', '10.0.0.1/32',
'127.0.0.1/32#1', { network: '127.0.0.1/32', ports: [1] },
'127.0.0.1/32#3,4,5', { network: '127.0.0.1/32', ports: [3, 4, 5] },
]); ]);
}); });
@ -32,6 +32,11 @@ describe(HttpRequestService, () => {
expect(result).toBeFalsy(); expect(result).toBeFalsy();
}); });
it('should return false when ip private and all ports undefined', () => {
const result = isPrivateIp(allowedPrivateNetworks, '10.0.0.1', undefined);
expect(result).toBeFalsy();
});
it('should return true when ip private and no ports specified', () => { it('should return true when ip private and no ports specified', () => {
const result = isPrivateIp(allowedPrivateNetworks, '10.0.0.2', 80); const result = isPrivateIp(allowedPrivateNetworks, '10.0.0.2', 80);
expect(result).toBeTruthy(); expect(result).toBeTruthy();
@ -41,6 +46,11 @@ describe(HttpRequestService, () => {
const result = isPrivateIp(allowedPrivateNetworks, '127.0.0.1', 80); const result = isPrivateIp(allowedPrivateNetworks, '127.0.0.1', 80);
expect(result).toBeTruthy(); expect(result).toBeTruthy();
}); });
it('should return true when ip private and port is null but ports are specified', () => {
const result = isPrivateIp(allowedPrivateNetworks, '127.0.0.1', undefined);
expect(result).toBeTruthy();
});
}); });
describe('validateSocketConnect', () => { describe('validateSocketConnect', () => {