From b888ff931d0eb76b0c03e606e9002c4f6d9197cb Mon Sep 17 00:00:00 2001 From: Hazelnoot Date: Tue, 13 May 2025 22:27:18 -0400 Subject: [PATCH] fix unit tests for HttpRequestService.ts --- .../backend/test/unit/core/HttpRequestService.ts | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/packages/backend/test/unit/core/HttpRequestService.ts b/packages/backend/test/unit/core/HttpRequestService.ts index 3185b91567..a2f4604e7b 100644 --- a/packages/backend/test/unit/core/HttpRequestService.ts +++ b/packages/backend/test/unit/core/HttpRequestService.ts @@ -16,8 +16,8 @@ describe(HttpRequestService, () => { beforeEach(() => { allowedPrivateNetworks = parsePrivateNetworks([ '10.0.0.1/32', - '127.0.0.1/32#1', - '127.0.0.1/32#3,4,5', + { network: '127.0.0.1/32', ports: [1] }, + { network: '127.0.0.1/32', ports: [3, 4, 5] }, ]); }); @@ -32,6 +32,11 @@ describe(HttpRequestService, () => { expect(result).toBeFalsy(); }); + it('should return false when ip private and all ports undefined', () => { + const result = isPrivateIp(allowedPrivateNetworks, '10.0.0.1', undefined); + expect(result).toBeFalsy(); + }); + it('should return true when ip private and no ports specified', () => { const result = isPrivateIp(allowedPrivateNetworks, '10.0.0.2', 80); expect(result).toBeTruthy(); @@ -41,6 +46,11 @@ describe(HttpRequestService, () => { const result = isPrivateIp(allowedPrivateNetworks, '127.0.0.1', 80); expect(result).toBeTruthy(); }); + + it('should return true when ip private and port is null but ports are specified', () => { + const result = isPrivateIp(allowedPrivateNetworks, '127.0.0.1', undefined); + expect(result).toBeTruthy(); + }); }); describe('validateSocketConnect', () => {