mirrors/barkey
1
0
Fork 0
mirror of https://codeberg.org/yeentown/barkey.git synced 2025-07-07 20:44:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

optimize extractUrlFromMfm

Browse source
This commit is contained in:
Hazelnoot 2025-05-20 22:33:14 -04:00
parent dc1adcc491
commit e74fde8b31
1 changed files with 24 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
packages/frontend/src/utility/extract-url-from-mfm.ts
View file

@ -4,22 +4,34 @@
*/ */
import * as mfm from '@transfem-org/sfm-js'; import * as mfm from '@transfem-org/sfm-js';
import { unique } from '@/utility/array.js';
// unique without hash // unique without hash
// [ http://a/#1, http://a/#2, http://b/#3 ] => [ http://a/#1, http://b/#3 ] // [ http://a/#1, http://a/#2, http://b/#3 ] => [ http://a/#1, http://b/#3 ]
const removeHash = (x: string) => x.replace(/#[^#]*$/, ''); const removeHash = (x: string) => {
if (URL.canParse(x)) {
const url = new URL(x);
url.hash = '';
return url.toString();
} else {
return x.replace(/#[^#]*$/, '');
}
};
// TODO this is O(n^2) which could introduce a frontend DoS with a large enough character limit
export function extractUrlFromMfm(nodes: mfm.MfmNode[], respectSilentFlag = true): string[] { export function extractUrlFromMfm(nodes: mfm.MfmNode[], respectSilentFlag = true): string[] {
const urlNodes = mfm.extract(nodes, (node) => { const urls = new Map<string, string>();
return (node.type === 'url') || (node.type === 'link' && (!respectSilentFlag || !node.props.silent));
});
const urls: string[] = unique(urlNodes.map(x => x.props.url));
return urls.reduce((array, url) => { // Single iteration pass to avoid potential DoS in maliciously-constructed notes.
const urlWithoutHash = removeHash(url); for (const node of nodes) {
if (!array.map(x => removeHash(x)).includes(urlWithoutHash)) array.push(url); if ((node.type === 'url') || (node.type === 'link' && (!respectSilentFlag || !node.props.silent))) {
return array; const url = (node as mfm.MfmUrl | mfm.MfmLink).props.url;
}, [] as string[]); const key = removeHash(url);
// Keep the first match only, to preserve existing behavior.
if (!urls.has(key)) {
urls.set(key, url);
}
}
}
return Array.from(urls.values());
} }