From ae52a80b1a304118b98bc52be44fae43984fb497 Mon Sep 17 00:00:00 2001 From: Hazelnoot Date: Tue, 4 Feb 2025 20:40:17 -0500 Subject: [PATCH] add simplified ti-emoji regex --- CONTRIBUTING.md | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e7cd453f72..daa11808c2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -692,16 +692,12 @@ seems to do a decent job) build` (the `development` tells it to keep some of the original filenames in the built files) * make sure there aren't any new `ti-*` classes (Tabler Icons), and - replace them with appropriate `ph-*` ones (Phosphor Icons): - `grep -rP '["'\'']ti[ -](?!fw)' -- built/` should show you what to change. - NOTE: `ti-fw` is a special class that's defined by Misskey, leave it - alone - - after every change, re-build the frontend and check again, until - there are no more `ti-*` classes in the built files (you can ignore - the source maps) - - commit! + replace them with appropriate `ph-*` ones (Phosphor Icons) in [`vite.replaceicons.ts`](packages/frontend/vite.replaceIcons.ts). + This command should show you want to change: `grep -ohrP '(?<=["'\'']ti )(ti-(?!fw)[\w\-]+)' --exclude \*.map -- built/ | sort -u`. + * NOTE: `ti-fw` is a special class that's defined by Misskey, leave it alone. + * After every change, re-build the frontend and check again, until + there are no more `ti-*` classes in the built files. + * Commit! * double-check the new migration, that they won't conflict with our db changes: `git diff develop -- packages/backend/migration/` * `pnpm clean; pnpm build`