From 64783994326d16185bbdbbee270365c5c50e4ef5 Mon Sep 17 00:00:00 2001 From: HellhoundSoftware Date: Mon, 13 Jan 2025 23:34:54 -0500 Subject: [PATCH] Don't sneakily disable RSS behind users' backs Also keeps the database shape consistent with what the ORM model says, because upstream forgot to do that. --- .../backend/migration/1733748798177-add_user_enableRss.js | 5 ++--- packages/backend/src/models/User.ts | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/backend/migration/1733748798177-add_user_enableRss.js b/packages/backend/migration/1733748798177-add_user_enableRss.js index 64662ca7b8..a699d1d0ef 100644 --- a/packages/backend/migration/1733748798177-add_user_enableRss.js +++ b/packages/backend/migration/1733748798177-add_user_enableRss.js @@ -2,9 +2,8 @@ export class AddUserEnableRss1733748798177 { name = 'AddUserEnableRss1733748798177' async up(queryRunner) { - // Disable by default, then specifically enable for all existing local users. - await queryRunner.query(`ALTER TABLE "user" ADD "enable_rss" boolean NOT NULL DEFAULT false`); - await queryRunner.query(`UPDATE "user" SET "enable_rss" = true WHERE host IS NULL;`) + // No, leave RSS enabled by default, WTF guys? + await queryRunner.query(`ALTER TABLE "user" ADD "enable_rss" boolean NOT NULL DEFAULT true`); } async down(queryRunner) { diff --git a/packages/backend/src/models/User.ts b/packages/backend/src/models/User.ts index 3a825d36a7..656e5f8c58 100644 --- a/packages/backend/src/models/User.ts +++ b/packages/backend/src/models/User.ts @@ -329,9 +329,8 @@ export class MiUser { public signupReason: string | null; /** - * True if profile RSS feeds are enabled for this user. - * Enabled by default (opt-out) for existing users, to avoid breaking any existing feeds. - * Disabled by default (opt-in) for newly created users, for privacy. + * True if profile RSS feeds are enabled for this user. Enabled by default. + * TODO: put the setting for this in the user wizard maybe? */ @Column('boolean', { name: 'enable_rss',