From 297666ac82d1689744a91fab37bcc876dcc7fd6a Mon Sep 17 00:00:00 2001 From: Hazelnoot Date: Wed, 2 Apr 2025 21:03:41 -0400 Subject: [PATCH] remove unused parameter from get-note-versions-menu.ts --- packages/frontend/src/components/MkNote.vue | 2 +- packages/frontend/src/components/MkNoteDetailed.vue | 2 +- packages/frontend/src/components/MkNoteHeader.vue | 2 +- packages/frontend/src/components/SkNote.vue | 2 +- packages/frontend/src/components/SkNoteDetailed.vue | 2 +- packages/frontend/src/components/SkNoteHeader.vue | 2 +- packages/frontend/src/utility/get-note-versions-menu.ts | 6 +----- 7 files changed, 7 insertions(+), 11 deletions(-) diff --git a/packages/frontend/src/components/MkNote.vue b/packages/frontend/src/components/MkNote.vue index 4f639e7566..51836ce093 100644 --- a/packages/frontend/src/components/MkNote.vue +++ b/packages/frontend/src/components/MkNote.vue @@ -820,7 +820,7 @@ function showMenu(): void { } async function menuVersions(): Promise { - const { menu, cleanup } = await getNoteVersionsMenu({ note: note.value, menuButton: menuVersionsButton }); + const { menu, cleanup } = await getNoteVersionsMenu({ note: note.value }); os.popupMenu(menu, menuVersionsButton.value).then(focus).finally(cleanup); } diff --git a/packages/frontend/src/components/MkNoteDetailed.vue b/packages/frontend/src/components/MkNoteDetailed.vue index 3f1e29a824..3c3136a705 100644 --- a/packages/frontend/src/components/MkNoteDetailed.vue +++ b/packages/frontend/src/components/MkNoteDetailed.vue @@ -760,7 +760,7 @@ function showMenu(): void { } async function menuVersions(): Promise { - const { menu, cleanup } = await getNoteVersionsMenu({ note: note.value, menuButton: menuVersionsButton }); + const { menu, cleanup } = await getNoteVersionsMenu({ note: note.value }); os.popupMenu(menu, menuVersionsButton.value).then(focus).finally(cleanup); } diff --git a/packages/frontend/src/components/MkNoteHeader.vue b/packages/frontend/src/components/MkNoteHeader.vue index 8cfb7338e5..84f9f26359 100644 --- a/packages/frontend/src/components/MkNoteHeader.vue +++ b/packages/frontend/src/components/MkNoteHeader.vue @@ -55,7 +55,7 @@ const props = defineProps<{ const menuVersionsButton = shallowRef(); async function menuVersions(): Promise { - const { menu, cleanup } = await getNoteVersionsMenu({ note: props.note, menuButton: menuVersionsButton }); + const { menu, cleanup } = await getNoteVersionsMenu({ note: props.note }); popupMenu(menu, menuVersionsButton.value).then(focus).finally(cleanup); } diff --git a/packages/frontend/src/components/SkNote.vue b/packages/frontend/src/components/SkNote.vue index 0e3a908ce0..1bb87462f7 100644 --- a/packages/frontend/src/components/SkNote.vue +++ b/packages/frontend/src/components/SkNote.vue @@ -820,7 +820,7 @@ function showMenu(): void { } async function menuVersions(): Promise { - const { menu, cleanup } = await getNoteVersionsMenu({ note: note.value, menuButton: menuVersionsButton }); + const { menu, cleanup } = await getNoteVersionsMenu({ note: note.value }); os.popupMenu(menu, menuVersionsButton.value).then(focus).finally(cleanup); } diff --git a/packages/frontend/src/components/SkNoteDetailed.vue b/packages/frontend/src/components/SkNoteDetailed.vue index 0bd3a078c7..767a589e1f 100644 --- a/packages/frontend/src/components/SkNoteDetailed.vue +++ b/packages/frontend/src/components/SkNoteDetailed.vue @@ -766,7 +766,7 @@ function showMenu(): void { } async function menuVersions(): Promise { - const { menu, cleanup } = await getNoteVersionsMenu({ note: note.value, menuVersionsButton }); + const { menu, cleanup } = await getNoteVersionsMenu({ note: note.value }); os.popupMenu(menu, menuVersionsButton.value).then(focus).finally(cleanup); } diff --git a/packages/frontend/src/components/SkNoteHeader.vue b/packages/frontend/src/components/SkNoteHeader.vue index 821c239e69..8d099eaf7a 100644 --- a/packages/frontend/src/components/SkNoteHeader.vue +++ b/packages/frontend/src/components/SkNoteHeader.vue @@ -101,7 +101,7 @@ const MOBILE_THRESHOLD = 500; const isMobile = ref(deviceKind === 'smartphone' || window.innerWidth <= MOBILE_THRESHOLD); async function menuVersions(): Promise { - const { menu, cleanup } = await getNoteVersionsMenu({ note: props.note, menuButton: menuVersionsButton }); + const { menu, cleanup } = await getNoteVersionsMenu({ note: props.note }); popupMenu(menu, menuVersionsButton.value).then(focus).finally(cleanup); } diff --git a/packages/frontend/src/utility/get-note-versions-menu.ts b/packages/frontend/src/utility/get-note-versions-menu.ts index f5182b1193..d9bfe7699c 100644 --- a/packages/frontend/src/utility/get-note-versions-menu.ts +++ b/packages/frontend/src/utility/get-note-versions-menu.ts @@ -7,7 +7,6 @@ import { defineAsyncComponent } from 'vue'; import * as Misskey from 'misskey-js'; import { misskeyApi } from './misskey-api.js'; import { dateTimeFormat } from './intl-const.js'; -import type { Ref } from 'vue'; import type { MenuItem } from '@/types/menu.js'; import * as os from '@/os.js'; @@ -17,10 +16,7 @@ interface NoteEdit { text: string | null; } -export async function getNoteVersionsMenu(props: { - note: Misskey.entities.Note; - menuButton: Ref; -}) { +export async function getNoteVersionsMenu(props: { note: Misskey.entities.Note }) { const isRenote = ( props.note.renote != null && props.note.text == null &&