mirrors/barkey
1
0
Fork 0
mirror of https://codeberg.org/yeentown/barkey.git synced 2025-07-07 12:36:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix inverted condition in resolveLocal

Browse source
This commit is contained in:
Hazelnoot 2025-06-08 19:57:01 -04:00
parent cb8ae13685
commit 141a92cf0c
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/backend/src/core/activitypub/ApResolverService.ts
View file

@ -347,6 +347,7 @@ export class Resolver {
return object; return object;
} }
// TODO try to remove this, as it creates a large attack surface
@bindThis @bindThis
private resolveLocal(url: string): Promise<IObjectWithId> { private resolveLocal(url: string): Promise<IObjectWithId> {
const parsed = this.apDbResolverService.parseUri(url); const parsed = this.apDbResolverService.parseUri(url);
@ -376,7 +377,7 @@ export class Resolver {
.then(([note, poll]) => this.apRendererService.renderQuestion({ id: note.userId }, note, poll)) as Promise<IObjectWithId>; .then(([note, poll]) => this.apRendererService.renderQuestion({ id: note.userId }, note, poll)) as Promise<IObjectWithId>;
case 'likes': case 'likes':
return this.noteReactionsRepository.findOneOrFail({ where: { id: parsed.id }, relations: { user: true } }).then(async reaction => { return this.noteReactionsRepository.findOneOrFail({ where: { id: parsed.id }, relations: { user: true } }).then(async reaction => {
if (reaction.user?.host == null) { if (reaction.user?.host != null) {
throw new IdentifiableError('02b40cd0-fa92-4b0c-acc9-fb2ada952ab8', `failed to resolve local ${url}: not a local reaction`); throw new IdentifiableError('02b40cd0-fa92-4b0c-acc9-fb2ada952ab8', `failed to resolve local ${url}: not a local reaction`);
} }
return this.apRendererService.addContext(await this.apRendererService.renderLike(reaction, { uri: null })); return this.apRendererService.addContext(await this.apRendererService.renderLike(reaction, { uri: null }));