mirror of
				https://codeberg.org/yeentown/barkey.git
				synced 2025-11-04 15:34:13 +00:00 
			
		
		
		
	refactor(backend): use Reflet for autobind deco (#14482)
Using Reflect.defineProperty instead of Object.defineProperty gives a more consistent behavior with the rest of the modern JavaScript features.
This commit is contained in:
		
							parent
							
								
									366b79e459
								
							
						
					
					
						commit
						07f26bc8dd
					
				
					 1 changed files with 7 additions and 14 deletions
				
			
		| 
						 | 
				
			
			@ -10,8 +10,9 @@
 | 
			
		|||
 * The getter will return a .bind version of the function
 | 
			
		||||
 * and memoize the result against a symbol on the instance
 | 
			
		||||
 */
 | 
			
		||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
 | 
			
		||||
export function bindThis(target: any, key: string, descriptor: any) {
 | 
			
		||||
	let fn = descriptor.value;
 | 
			
		||||
	const fn = descriptor.value;
 | 
			
		||||
 | 
			
		||||
	if (typeof fn !== 'function') {
 | 
			
		||||
		throw new TypeError(`@bindThis decorator can only be applied to methods not: ${typeof fn}`);
 | 
			
		||||
| 
						 | 
				
			
			@ -21,26 +22,18 @@ export function bindThis(target: any, key: string, descriptor: any) {
 | 
			
		|||
		configurable: true,
 | 
			
		||||
		get() {
 | 
			
		||||
			// eslint-disable-next-line no-prototype-builtins
 | 
			
		||||
			if (this === target.prototype || this.hasOwnProperty(key) ||
 | 
			
		||||
        typeof fn !== 'function') {
 | 
			
		||||
			if (this === target.prototype || this.hasOwnProperty(key)) {
 | 
			
		||||
				return fn;
 | 
			
		||||
			}
 | 
			
		||||
 | 
			
		||||
			const boundFn = fn.bind(this);
 | 
			
		||||
			Object.defineProperty(this, key, {
 | 
			
		||||
			Reflect.defineProperty(this, key, {
 | 
			
		||||
				value: boundFn,
 | 
			
		||||
				configurable: true,
 | 
			
		||||
				get() {
 | 
			
		||||
					return boundFn;
 | 
			
		||||
				},
 | 
			
		||||
				set(value) {
 | 
			
		||||
					fn = value;
 | 
			
		||||
					delete this[key];
 | 
			
		||||
				},
 | 
			
		||||
				writable: true,
 | 
			
		||||
			});
 | 
			
		||||
 | 
			
		||||
			return boundFn;
 | 
			
		||||
		},
 | 
			
		||||
		set(value: any) {
 | 
			
		||||
			fn = value;
 | 
			
		||||
		},
 | 
			
		||||
	};
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		
		Reference in a new issue